[
https://issues.apache.org/jira/browse/BEAM-5633?focusedWorklogId=152903&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-152903
]
ASF GitHub Bot logged work on BEAM-5633:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Oct/18 20:03
Start Date: 09/Oct/18 20:03
Worklog Time Spent: 10m
Work Description: aaltay commented on a change in pull request #6593:
[BEAM-5633] Adds reconnect logic to python logging client
URL: https://github.com/apache/beam/pull/6593#discussion_r223843243
##########
File path: sdks/python/apache_beam/runners/worker/log_handler.py
##########
@@ -106,7 +120,19 @@ def _write_log_entries(self):
if log_entries:
yield beam_fn_api_pb2.LogEntry.List(log_entries=log_entries)
- def _read_log_control_messages(self, log_control_iterator):
- # TODO(vikasrk): Handle control messages.
- for _ in log_control_iterator:
- pass
+ def _read_log_control_messages(self):
+ while True:
+ log_control_iterator = self.connect()
+ if self._dropped_logs > 0:
+ logging.warn("Dropped %d logs while logging client disconnected",
Review comment:
I do not want to block this PR. Let's merge. but I have a follow up question.
If the queue is already full, would not this message be also dropped as
well. (Unless the log write gets scheduled in between connection and this log
message?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 152903)
Time Spent: 2.5h (was: 2h 20m)
> Python SDK harness logging client failure
> -----------------------------------------
>
> Key: BEAM-5633
> URL: https://issues.apache.org/jira/browse/BEAM-5633
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-harness
> Reporter: Thomas Weise
> Assignee: Micah Wylde
> Priority: Major
> Labels: portability-flink
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> After running a test with synthetic source for a few minutes, the logging
> client fails and all subsequent log output is not forwarded to the runner.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
