[
https://issues.apache.org/jira/browse/BEAM-5624?focusedWorklogId=153498&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-153498
]
ASF GitHub Bot logged work on BEAM-5624:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Oct/18 12:52
Start Date: 11/Oct/18 12:52
Worklog Time Spent: 10m
Work Description: splovyt commented on a change in pull request #6616:
[BEAM-5624] Fix avro.schema parser for py3
URL: https://github.com/apache/beam/pull/6616#discussion_r224434770
##########
File path: sdks/python/apache_beam/io/avroio_test.py
##########
@@ -25,10 +25,15 @@
from builtins import range
import avro.datafile
-import avro.schema
from avro.datafile import DataFileWriter
from avro.io import DatumWriter
import hamcrest as hc
+# pylint: disable=wrong-import-order, wrong-import-position, ungrouped-imports
+try:
+ from avro.schema import Parse
Review comment:
Thank you both for the feedback.
@aaltay I have added a comment stating that python2 uses the 'avro' library,
whereas python3 uses 'avro-python3'.
@tvalentyn I have made the changes in the related files as well.
Note that although I had disabled pylint wrong-import-order and
wrong-import-position, it still did not pass the precommit check so I had to
reposition the imports to continue, PTAL, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 153498)
Time Spent: 50m (was: 40m)
> Avro IO does not work with avro-python3 package out-of-the-box on Python 3,
> several tests fail with AttributeError (module 'avro.schema' has no attribute
> 'parse')
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: BEAM-5624
> URL: https://issues.apache.org/jira/browse/BEAM-5624
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Valentyn Tymofieiev
> Assignee: Simon
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> ======================================================================
> ERROR: Failure: AttributeError (module 'avro.schema' has no attribute 'parse')
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File
> "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/target/.tox/py3/lib/python3.5/site-packages/nose/failure.py",
> line 39, in runTest
> raise self.exc_val.with_traceback(self.tb)
> File
> "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/target/.tox/py3/lib/python3.5/site-packages/nose/loader.py",
> line 418, in loadTestsFromName
> addr.filename, addr.module)
> File
> "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/target/.tox/py3/lib/python3.5/site-packages/nose/importer.py",
> line 47, in importFromPath
> return self.importFromDir(dir_path, fqname)
> File
> "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/target/.tox/py3/lib/python3.5/site-packages/nose/importer.py",
> line 94, in importFromDir
> mod = load_module(part_fqname, fh, filename, desc)
> File
> "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/target/.tox/py3/lib/python3.5/imp.py",
> line 234, in load_module
> return load_source(name, filename, file)
> File
> "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/target/.tox/py3/lib/python3.5/imp.py",
> line 172, in load_source
> module = _load(spec)
> File "<frozen importlib._bootstrap>", line 693, in _load
> File "<frozen importlib._bootstrap>", line 673, in _load_unlocked
> File "<frozen importlib._bootstrap_external>", line 673, in exec_module
> File "<frozen importlib._bootstrap>", line 222, in _call_with_frames_removed
> File
> "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/io/avroio_test.py",
> line 54, in <module>
> class TestAvro(unittest.TestCase):
> File
> "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/io/avroio_test.py",
> line 89, in TestAvro
> SCHEMA = avro.schema.parse('''
> AttributeError: module 'avro.schema' has no attribute 'parse'
> Note that we use a different implementation of avro/avro-python3 package
> depending on Python version. We are also evaluating potential replacement of
> avro with fastavro.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
