This is an automated email from the ASF dual-hosted git repository.

jaku pushed a commit to branch dot-log
in repository https://gitbox.apache.org/repos/asf/beam.git

commit c33dd9eae2185014cf4bd6f5bc7ecd6405378ad7
Author: jasonkuster <jasonkus...@google.com>
AuthorDate: Thu Apr 11 17:12:46 2019 -0700

    Add the appropriate extension to log files.
    
    Files are created with the filename.<date> extension which is not a valid 
filetype and can cause difficulties for people when trying to open logs. Set it 
to add an appropriate extension instead.
---
 .../runners/dataflow/worker/logging/DataflowWorkerLoggingHandler.java   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/logging/DataflowWorkerLoggingHandler.java
 
b/runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/logging/DataflowWorkerLoggingHandler.java
index 7428390..0fdb4ae 100644
--- 
a/runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/logging/DataflowWorkerLoggingHandler.java
+++ 
b/runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/logging/DataflowWorkerLoggingHandler.java
@@ -273,7 +273,7 @@ public class DataflowWorkerLoggingHandler extends Handler {
     @Override
     public OutputStream get() {
       try {
-        String filename = filepath + "." + formatter.format(new Date());
+        String filename = filepath + "." + formatter.format(new Date()) + 
".log";
         return new BufferedOutputStream(
             new FileOutputStream(new File(filename), true /* append */));
       } catch (IOException e) {

Reply via email to