This is an automated email from the ASF dual-hosted git repository.

pabloem pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git


The following commit(s) were added to refs/heads/master by this push:
     new 3a43442  Add clarifying comment for MonitoringInfoLabel usage.
     new 21f6320  Merge pull request #8440 from ajamato/patch-3
3a43442 is described below

commit 3a43442b2d5619d047f0c6bbf6d94b002b378f67
Author: Alex Amato <[email protected]>
AuthorDate: Tue Apr 30 12:02:05 2019 -0700

    Add clarifying comment for MonitoringInfoLabel usage.
---
 model/pipeline/src/main/proto/metrics.proto | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/model/pipeline/src/main/proto/metrics.proto 
b/model/pipeline/src/main/proto/metrics.proto
index 3b45efb..3dfd643 100644
--- a/model/pipeline/src/main/proto/metrics.proto
+++ b/model/pipeline/src/main/proto/metrics.proto
@@ -175,7 +175,11 @@ message MonitoringInfo {
   }
 
   enum MonitoringInfoLabels {
-    // TODO(ajamato): Rename all references to TRANSFORM to PTRANSFORM
+    // TODO(ajamato): Rename all references from TRANSFORM to PTRANSFORM
+
+    // The values used for TRANSFORM, PCOLLECTION, WINDOWING_STRATEGY
+    // CODER, ENVIRONMENT, etc. must always match the keys used to
+    // refer to them in the ProcessBundleDescriptor.
     TRANSFORM = 0 [(label_props) = { name: "PTRANSFORM" }];
     PCOLLECTION = 1 [(label_props) = { name: "PCOLLECTION" }];
     WINDOWING_STRATEGY = 2 [(label_props) = { name: "WINDOWING_STRATEGY" }];

Reply via email to