lukecwik commented on a change in pull request #10980: Address leftover styling
comments from PR/10892
URL: https://github.com/apache/beam/pull/10980#discussion_r384763184
##########
File path: sdks/python/apache_beam/testing/test_stream.py
##########
@@ -148,9 +148,8 @@ def __lt__(self, other):
def to_runner_api(self, unused_element_coder):
tag = 'None' if self.tag is None else self.tag
- # Assert that no prevision is lost.
- assert 1000 * (
- self.new_watermark.micros // 1000) == self.new_watermark.micros
+ # Assert that no precision is lost.
+ assert self.new_watermark.micros % 1000 == 0
Review comment:
can you do this for processing time events as well
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
