pawelpasterz commented on a change in pull request #10878: Implement precommit portability test to run on java 11 URL: https://github.com/apache/beam/pull/10878#discussion_r384834326
########## File path: runners/google-cloud-dataflow-java/examples/build.gradle ########## @@ -97,6 +97,42 @@ task verifyPortabilityApi() { dependsOn verifyFnApiWorker } +def passedDockerImageName = project.findProperty('passedDockerImageName') +def java8Home = project.findProperty('java8Home') +def java11Home = project.findProperty('java11Home') + +task runFnApiTest(type: Test) { + def dataflowWorkerJar = project.findProperty('dataflowWorkerJar') ?: project(":runners:google-cloud-dataflow-java:worker").shadowJar.archivePath + with commonConfig(dataflowWorkerJar, passedDockerImageName, ["--experiments=${fnapiExperiments}"]) + useJUnit { + excludeCategories 'org.apache.beam.sdk.testing.StreamingIT' + } +} + +task verifyFnApiWorkerJava11(type: Test) { + dependsOn ":runners:google-cloud-dataflow-java:worker:shadowJar" + dependsOn ":runners:google-cloud-dataflow-java:buildAndPushDockerContainer" + doLast { + exec { + workingDir "${rootProject.projectDir}" + commandLine "./gradlew", "${project.path}:runFnApiTest", "-Pjava8Home=${java8Home}", "-PcompileWithJava8", "-PpassedDockerImageName=${dockerImageName}", "-x shadowJar", "-x shadowTestJar", "-x jar", "-x testJar", "-x classes", "-x testClasses", "-PdisableSpotlessCheck=true", "-Dorg.gradle.java.home=${java11Home}" Review comment: @kennknowles I also need to pass proper docker image name. That is the reason why I did it this way ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services