robertwb commented on a change in pull request #10621: [BEAM-9056] Staging
artifacts from environment
URL: https://github.com/apache/beam/pull/10621#discussion_r384850669
##########
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/SdkComponents.java
##########
@@ -88,11 +88,13 @@ public static SdkComponents create(RunnerApi.Components
components) {
public static SdkComponents create(PipelineOptions options) {
SdkComponents sdkComponents = new
SdkComponents(RunnerApi.Components.getDefaultInstance(), "");
PortablePipelineOptions portablePipelineOptions =
options.as(PortablePipelineOptions.class);
- sdkComponents.defaultEnvironmentId =
- sdkComponents.registerEnvironment(
- Environments.createOrGetDefaultEnvironment(
+ sdkComponents.registerEnvironment(
+ Environments.createOrGetDefaultEnvironment(
portablePipelineOptions.getDefaultEnvironmentType(),
- portablePipelineOptions.getDefaultEnvironmentConfig()));
+ portablePipelineOptions.getDefaultEnvironmentConfig())
+ .toBuilder()
+ .addAllDependencies(Environments.getArtifacts(options))
Review comment:
Would this be better placed in createOrGetDefaultEnvironment?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
