Tesio commented on a change in pull request #10914: [BEAM-8078] streaming_wordcount_debugging.py is missing a test URL: https://github.com/apache/beam/pull/10914#discussion_r385392760
########## File path: sdks/python/apache_beam/examples/streaming_wordcount_debugging.py ########## @@ -71,16 +72,14 @@ def process( class AddTimestampFn(beam.DoFn): """A DoFn that attaches timestamps to its elements. - It takes a string of integers and it attaches to each of them - a timestamp of its same value. + It just takes an element and adds a current timestamp. - For example, [120, 225, 312] will result in: - [(120, Timestamp(120)), (225, Timestamp(225)), (312, Timestamp(312))]. + For example, Sometext will result in: + (Sometext, Timestamp(1234567890). Review comment: Well, as this is an example of debugging functionality - more complicated logic could be added during real-time development. Just to keep it simple for windowing and applicable for strings as well - what about basing on string's length to keep it predictable. And keeping int-base for int values? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
