kennknowles commented on a change in pull request #11004: Adds DisplayData for
StateSpecs used by stateful ParDos
URL: https://github.com/apache/beam/pull/11004#discussion_r385931847
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ParDo.java
##########
@@ -903,11 +902,53 @@ public String toString() {
}
}
+ private static String stateDescription(StateSpec<?> spec) {
+ return spec.match(
+ new StateSpec.Cases<String>() {
+ @Override
+ public String dispatchValue(Coder<?> valueCoder) {
+ return "ValueState<" + valueCoder + ">";
Review comment:
Here, too, maybe using the format of
`MoreObjects.toStringHelper(this).add("coder", valueCoder)` will make it all
uniform. But since this is really a helper for display data, and `DisplayData`
can be structured (somewhat?) it probably makes sense to structure it here
using
https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/display/DisplayData.java#L145
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
