steveniemitz commented on issue #10852: [BEAM-9308] Decorrelate state cleanup 
timers
URL: https://github.com/apache/beam/pull/10852#issuecomment-592959333
 
 
   > maybe we need to explore the prioritization issue a bit more.
   
   Agreed, I think ideally the state cleanup timers would have a (much?) lower 
priority than everything else so they don't starve out more important "user" 
work.
   
   > Is this. a blocker for. you? If so then. maybe we can add a parameter to 
DataflowPipelineOptions to control this so we don't take the risk of changing 
the default behavior without more data.
   
   We run our own fork of the anyways, so it's not particularly a blocker here. 
 I mostly just intended this PR as a conversation starter.
   
   I am curious about your comment above though ("We currently rely on the 
state cleanup timer for watermark holds").  From what I've observed in the 
code, the state cleanup is set for after the window end, so delaying it 
slightly more shouldn't cause any correctness issues, correct?
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to