pabloem commented on a change in pull request #10994: [BEAM-8335]
TeststreamService integration with DirectRunner
URL: https://github.com/apache/beam/pull/10994#discussion_r387979245
##########
File path: sdks/python/apache_beam/testing/test_stream_service.py
##########
@@ -52,5 +56,9 @@ def stop(self):
def Events(self, request, context):
"""Streams back all of the events from the streaming cache."""
- for e in self._events:
+ # TODO(srohde): Once we get rid of the CacheManager, get rid of this 'full'
+ # label.
+ reader = self._reader.read_multiple([['full', key]
Review comment:
s/key/tag/ ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
