youngoli commented on a change in pull request #10991: [BEAM-3301] Refactor DoFn validation & allow specifying main inputs. URL: https://github.com/apache/beam/pull/10991#discussion_r388609914
########## File path: sdks/go/pkg/beam/core/graph/fn.go ########## @@ -209,21 +209,74 @@ func (f *DoFn) RestrictionT() *reflect.Type { // a KV or not based on the other signatures (unless we're more loose about which // sideinputs are present). Bind should respect that. +// The following constants prefixed with "Main" represent possible numbers of +// DoFn main inputs for DoFn construction and validation. Any value not defined +// here is an invalid number of main inputs. +const ( + MainUnknown = -1 // The number of main inputs is unknown for DoFn validation. Review comment: I'm leaving it exported only because AsDoFn is currently exported and takes one of these constants as an input. Making this unexported would make it impossible to call AsDoFn with the existing behavior (unknown num. of inputs). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services