iemejia edited a comment on issue #11076: Run precommit portability on java 11
URL: https://github.com/apache/beam/pull/11076#issuecomment-599387419
 
 
   I see, your approach makes sense notice that my first comment is because we 
do not run examples as part of other VR tests, notice how slow the examples are 
in comparison with the tests, so maybe worth to split them as is already the 
case for Java 8.
   
   The postcommit point is arguable as you mention. In any case if Java 11 is 
broken on postcommit we will notice it if not quickly at least at pre release 
time. We can consider it by default but that means extra time for everyone so 
the point is if it is worth or not. I don't think we run the tests for every 
python version in precommit. We should probably be consistent.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to