chadrik commented on a change in pull request #11038: [BEAM-7746] More typing
fixes
URL: https://github.com/apache/beam/pull/11038#discussion_r393187810
##########
File path: sdks/python/apache_beam/runners/worker/sdk_worker.py
##########
@@ -724,8 +738,9 @@ def pull_responses():
reader.start()
def done(self):
+ # type: () -> None
self._done = True
- self._requests.put(self._DONE)
+ self._requests.put(self._DONE) # type: ignore[arg-type]
Review comment:
another opportunity for the `Sentinel` pattern
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
