suztomo commented on a change in pull request #11156: [BEAM-9444] Use GCP
Libraries BOM for Google Cloud Dependencies
URL: https://github.com/apache/beam/pull/11156#discussion_r394408735
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -1274,7 +1296,9 @@ class BeamModulePlugin implements Plugin<Project> {
// has different dependencies than our project.
if (config.getName() != "errorprone" && !inDependencyUpdates) {
config.resolutionStrategy {
- force project.library.java.values()
+ // Filtering versionless coordinates that depend on BOM
+ def librariesWithVersion = project.library.java.values().findAll {
it.split(':').size() > 2 }
+ force librariesWithVersion
Review comment:
@lukecwik Do you still need this `force` of the dependency versions? (I
found your commit in 2017
https://github.com/apache/beam/commit/aee22a9dcf9284cd362f6ed91a43e1c68cd65be3 )
I assume this `force` was introduced to pass the compilation and tests by
resolving the exact versions of the dependencies when building Beam. However
Beam users (both Gradle and Maven) do not have this version-pinning effect when
using Beam. Therefore this `force` might have hidden dependency problems that
Beam developers could discover when running tests.
Do you still need this `force`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
