lostluck commented on a change in pull request #11144: [BEAM-3301] Perform SDF
validation (missing RestrictionTrackers).
URL: https://github.com/apache/beam/pull/11144#discussion_r394728377
##########
File path: sdks/go/pkg/beam/core/graph/fn_test.go
##########
@@ -470,6 +542,169 @@ func (fn *BadDoFnAmbiguousSideInput) StartBundle(bool) {
func (fn *BadDoFnAmbiguousSideInput) FinishBundle(bool) {
}
+// Examples of correct SplittableDoFn signatures
+
+type RestT struct{}
+
+type GoodSdf struct {
Review comment:
Shouldn't the ProcessElement method be adjusted here for the Restriction
tracker parameter for a "GoodSdf" ?
I guess technically if we don't care about dynamic splitting at all, it
should be allowed. It's not unreasonable to prevent it until we have the right
idea how to do that, but if so, lets put a TODO in here somewhere to make the
intent explicit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
