ajamato commented on a change in pull request #11184: [WIP][BEAM-4374] Update
protos related to MonitoringInfo.
URL: https://github.com/apache/beam/pull/11184#discussion_r395889104
##########
File path: model/pipeline/src/main/proto/metrics.proto
##########
@@ -194,33 +188,25 @@ extend google.protobuf.EnumValueOptions {
}
message MonitoringInfo {
- // The name defining the metric or monitored state.
+ // The name defining the semantic meaning of the metric or monitored state.
+ //
+ // See MonitoringInfoSpecs.Enum for the set of well known metrics/monitored
+ // state.
string urn = 1;
- // This is specified as a URN that implies:
- // A message class: (Distribution, Counter, Extrema, MonitoringDataTable).
- // Sub types like field formats - int64, double, string.
- // Aggregation methods - SUM, LATEST, TOP-N, BOTTOM-N, DISTRIBUTION
- // valid values are:
- // beam:metrics:[sum_int_64|latest_int_64|top_n_int_64|bottom_n_int_64|
- // sum_double|latest_double|top_n_double|bottom_n_double|
- // distribution_int_64|distribution_double|monitoring_data_table|
- // latest_doubles
+ // This is specified as a URN that implies the encoding and aggregation
+ // method. See MonitoringInfoTypeUrns.Enum for the set of well known types.
string type = 2;
- // The Metric or monitored state.
- oneof data {
- MonitoringTableData monitoring_table_data = 3;
- Metric metric = 4;
- bytes payload = 7;
- }
+ // The monitored state encoded as per the specification defined by the type.
+ bytes payload = 3;
Review comment:
My biggest concern is losing the ability to print debug strings, which are
helpful when people are trying to learn how these are populated. But maybe we
can just add a few obvious places to dump debug logs, debug files, etc with the
MonitoringInfors parses properly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
