This is an automated email from the ASF dual-hosted git repository. lostluck pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/beam.git
The following commit(s) were added to refs/heads/master by this push: new 93f41ce [BEAM-13699] Replace fnv with maphash. (#16573) 93f41ce is described below commit 93f41ce1e3d245d7decd1d9b7c4768e51a90b39b Author: Robert Burke <lostl...@users.noreply.github.com> AuthorDate: Thu Jan 20 11:16:30 2022 -0800 [BEAM-13699] Replace fnv with maphash. (#16573) --- sdks/go/pkg/beam/core/runtime/exec/hash.go | 5 ++--- sdks/go/pkg/beam/core/runtime/exec/hash_test.go | 4 ++-- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/sdks/go/pkg/beam/core/runtime/exec/hash.go b/sdks/go/pkg/beam/core/runtime/exec/hash.go index db2d0b6..70fbfa0 100644 --- a/sdks/go/pkg/beam/core/runtime/exec/hash.go +++ b/sdks/go/pkg/beam/core/runtime/exec/hash.go @@ -19,7 +19,7 @@ import ( "encoding/binary" "fmt" "hash" - "hash/fnv" + "hash/maphash" "math" "reflect" @@ -35,8 +35,7 @@ type elementHasher interface { } func makeElementHasher(c *coder.Coder, wc *coder.WindowCoder) elementHasher { - // TODO(lostluck): move to a faster hashing library once we can take dependencies easily. - hasher := fnv.New64a() + hasher := &maphash.Hash{} we := MakeWindowEncoder(wc) switch c.Kind { case coder.Bytes: diff --git a/sdks/go/pkg/beam/core/runtime/exec/hash_test.go b/sdks/go/pkg/beam/core/runtime/exec/hash_test.go index 7d2c3de..528dfd0 100644 --- a/sdks/go/pkg/beam/core/runtime/exec/hash_test.go +++ b/sdks/go/pkg/beam/core/runtime/exec/hash_test.go @@ -18,7 +18,7 @@ package exec import ( "encoding/json" "fmt" - "hash/fnv" + "hash/maphash" "reflect" "strings" "testing" @@ -32,7 +32,7 @@ import ( func BenchmarkPrimitives(b *testing.B) { var value FullValue - myHash := fnv.New64a() + myHash := &maphash.Hash{} wfn := window.NewGlobalWindows() we := MakeWindowEncoder(wfn.Coder()) b.Run("int", func(b *testing.B) {