GitHub user tgroh opened a pull request: https://github.com/apache/incubator-beam/pull/128
Fix tests marked RunnableOnService that aren't Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make sure the PR title is formatted like: `[BEAM-<Jira issue #>] Description of pull request` - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable Travis-CI on your fork and ensure the whole test matrix passes). - [ ] Replace "<Jira issue #>" in the title with the actual Jira issue number, if there is one. - [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt). --- Tests must make exclusively assertions about the contents of PCollections to be marked RunnableOnService. Tests making assertions about the client result cannot be ported between runners and do not meet this requirement. RunnableOnService tests that expect a specific exception as a result of the pipeline failing are not portable. Remove the RunnableOnService category from DoFnTest, DoFnWithContextTest, and WithTimestampTest tests which expect exceptions. You can merge this pull request into a Git repository by running: $ git pull https://github.com/tgroh/incubator-beam do_fn_test_not_ros Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-beam/pull/128.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #128 ---- commit e7db194965c35e81e3117b1675d08c67e1bb0f24 Author: Thomas Groh <tg...@google.com> Date: 2016-04-05T19:35:10Z Fix tests marked RunnableOnService that aren't Tests must make exclusively assertions about the contents of PCollections to be marked RunnableOnService. Tests making assertions about the client result cannot be ported between runners and do not meet this requirement. RunnableOnService tests that expect a specific exception as a result of the pipeline failing are not portable. Remove the RunnableOnService category from DoFnTest, DoFnWithContextTest, and WithTimestampTest tests which expect exceptions. ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---