[ 
https://issues.apache.org/jira/browse/BEAM-151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15238494#comment-15238494
 ] 

ASF GitHub Bot commented on BEAM-151:
-------------------------------------

GitHub user lukecwik opened a pull request:

    https://github.com/apache/incubator-beam/pull/173

    [BEAM-151] Add support for RunnableOnService validation tests to runners 
module

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace "<Jira issue #>" in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    Default implementation for Dataflow requires you to specify the 
runnableOnServicePipelineOptions
    system property with a valid project/runner/... to be able to execute on 
Google Cloud Dataflow.
    
    Default implementation for Flink and Spark are to have it disabled.
    
    Note the whitespace formatting fix on spark pom.xml

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lukecwik/incubator-beam dataflow-runner-7

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/173.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #173
    
----
commit 60d5471f74df1da5979dc31a6a7ee11c6fe1a850
Author: Luke Cwik <lc...@google.com>
Date:   2016-04-13T00:49:07Z

    [BEAM-151] Add support for RunnableOnService validation tests to runners 
package
    
    Default implementation for Flink and Spark are to have it disabled.
    Default implementation for Dataflow requires you to specify the 
runnableOnServicePipelineOptions
    system property with a valid project/runner/... to be able to execute on 
Google Cloud Dataflow.

commit 86e61c5f91f02340b42e3608b0b949f6384ae3d9
Author: Luke Cwik <lc...@google.com>
Date:   2016-04-13T02:50:49Z

    [BEAM-151] !fixup Add the runnable-on-service-tests execution

commit c1b4f3350b830f726e169999cfe6db0d6b337022
Author: Luke Cwik <lc...@google.com>
Date:   2016-04-13T02:54:45Z

    [BEAM-151] !fixup Fix comment in TestPipeline

----


> Create Dataflow Runner Package
> ------------------------------
>
>                 Key: BEAM-151
>                 URL: https://issues.apache.org/jira/browse/BEAM-151
>             Project: Beam
>          Issue Type: Improvement
>          Components: runner-dataflow
>            Reporter: Luke Cwik
>            Assignee: Luke Cwik
>
> Move Dataflow runner out of SDK core and into new Dataflow runner maven 
> module.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to