GitHub user tgroh opened a pull request:
https://github.com/apache/incubator-beam/pull/188
[BEAM-22] Improve ParDoEvaluator Factoring
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
This moves shared code into a common location.
Clone DoFn instances before constructing the DoFnRunner to
avoid races.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tgroh/incubator-beam
ippr_better_ParDoEvaluator_factoring
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/188.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #188
----
commit ecc26d51cee4ea1568948d48cd3441594f638e39
Author: Thomas Groh <tg...@google.com>
Date: 2016-03-30T00:38:22Z
Move Shared construction code to ParDoInProcessEvaluator
Remove duplicate code in ParDo(Single/Multi)EvaluatorFactory; instead
only extract the appropriate elements and pass them to the
ParDoInProcessEvaluator.t log
commit e47aba0a7097cee8341369594e47e73b83029a50
Author: Thomas Groh <tg...@google.com>
Date: 2016-04-15T17:23:15Z
Clone DoFns before constructing a DoFnRunner
This ensures that each thread gets an individual copy of a DoFn, so
multiple threads do not interact.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
