[ https://issues.apache.org/jira/browse/BEAM-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15248133#comment-15248133 ]
ASF GitHub Bot commented on BEAM-208: ------------------------------------- GitHub user tgroh opened a pull request: https://github.com/apache/incubator-beam/pull/210 [BEAM-208] Remove use of System.currentTimeMillis in Flink Test Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make sure the PR title is formatted like: `[BEAM-<Jira issue #>] Description of pull request` - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable Travis-CI on your fork and ensure the whole test matrix passes). - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue number, if there is one. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt). --- This will stop tests failing if the DoFn executes within ~25 seconds of an hour boundary. You can merge this pull request into a Git repository by running: $ git pull https://github.com/tgroh/incubator-beam flink_deflake_groupByKeyNull Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-beam/pull/210.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #210 ---- commit 416ca1f5e589b19e9e98e68fbb0e35349e19b82d Author: Thomas Groh <tg...@google.com> Date: 2016-04-19T16:39:38Z Remove use of System.currentTimeMillis in Flink Test This will stop tests failing if the DoFn executes within ~25 seconds of an hour boundary. ---- > Flaky test: org.apache.beam.runners.flink.streaming.GroupByNullKeyTest.testJob > ------------------------------------------------------------------------------ > > Key: BEAM-208 > URL: https://issues.apache.org/jira/browse/BEAM-208 > Project: Beam > Issue Type: Bug > Components: runner-flink > Reporter: Davor Bonaci > Assignee: Maximilian Michels > Priority: Minor > > org.apache.beam.runners.flink.streaming.GroupByNullKeyTest.testJob sometimes > flakes out. > Error: > Different number of lines in expected and obtained result. expected:<1> but > was:<2> > Here's an example on Jenkins: > https://builds.apache.org/job/beam_PostCommit_MavenVerify/org.apache.beam$flink-runner_2.10/199/testReport/junit/org.apache.beam.runners.flink.streaming/GroupByNullKeyTest/testJob/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)