[
https://issues.apache.org/jira/browse/BEAM-210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15248488#comment-15248488
]
ASF GitHub Bot commented on BEAM-210:
-------------------------------------
GitHub user bjchambers opened a pull request:
https://github.com/apache/incubator-beam/pull/211
[BEAM-210] Test that empty final panes are not produced.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [x] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [x] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bjchambers/incubator-beam empty-final-panes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/211.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #211
----
commit cae541795c632f5ba4799b24a730018ec75ffb1b
Author: bchambers <bchamb...@google.com>
Date: 2016-04-19T18:34:25Z
Remove unused generic arguments in ReduceFnRunnerTest.
commit 4ab1c175f188e03f0ef2a5b6b2019c1e0ba27260
Author: bchambers <bchamb...@google.com>
Date: 2016-04-19T19:43:52Z
Add test for empty ON_TIME and no empty final pane
Add a test that we get an empty `ON_TIME` pane, and don't get the empty
final pane when using accumulation mode with the only if non-empty
`ClosingBehavior`.
----
> Be consistent with emitting final empty panes
> ---------------------------------------------
>
> Key: BEAM-210
> URL: https://issues.apache.org/jira/browse/BEAM-210
> Project: Beam
> Issue Type: Bug
> Components: runner-core
> Reporter: Mark Shields
> Assignee: Mark Shields
>
> Currently ReduceFnRunner.onTrigger uses shouldEmit to prevent empty final
> panes unless the user has requested them.
> The same check needs to be done in ReduceFnRunner.onTimer
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
