[ https://issues.apache.org/jira/browse/BEAM-157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15250620#comment-15250620 ]
ASF GitHub Bot commented on BEAM-157: ------------------------------------- GitHub user kennknowles opened a pull request: https://github.com/apache/incubator-beam/pull/218 [BEAM-157] Fix erroneous test in CombineTest Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [x] Make sure the PR title is formatted like: `[BEAM-<Jira issue #>] Description of pull request` - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable Travis-CI on your fork and ensure the whole test matrix passes). - [x] Replace `<Jira issue #>` in the title with the actual Jira issue number, if there is one. - [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt). --- You can merge this pull request into a Git repository by running: $ git pull https://github.com/kennknowles/incubator-beam CombineTest Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-beam/pull/218.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #218 ---- commit 4c9dd22501ff931e19f41661018795d328b31295 Author: Kenneth Knowles <k...@google.com> Date: 2016-04-20T19:58:08Z Unabbreviate some variable names commit 4416567961ccaa93ad884dcbcaf5e8c6d63f422a Author: Kenneth Knowles <k...@google.com> Date: 2016-04-20T20:12:48Z Fix erroneous test in CombineTest The test modified was never run, so we never learned that it was incorrect. This change activates the test and fixes it. ---- > CombineTest.testGlobalCombineWithDefaultsAndTriggers is broken > -------------------------------------------------------------- > > Key: BEAM-157 > URL: https://issues.apache.org/jira/browse/BEAM-157 > Project: Beam > Issue Type: Bug > Components: sdk-java-core > Reporter: Daniel Halperin > Assignee: Kenneth Knowles > Priority: Critical > > The test is not run because `p.run()` is not called. When `p.run()` is added, > the test fails. > Kenn, I suspect this is because it's using triggers in batch, which obviously > is not guaranteed to work. > Please investigate! > https://github.com/apache/incubator-beam/blob/master/sdks/java/core/src/test/java/com/google/cloud/dataflow/sdk/transforms/CombineTest.java#L373 > Failed tests: > CombineTest.testGlobalCombineWithDefaultsAndTriggers:391 > Expected: iterable over ["2: true", "1: false"] in any order > but: No item matches: "1: false" in ["2: true"] > Tests run: 30, Failures: 1, Errors: 0, Skipped: 0 -- This message was sent by Atlassian JIRA (v6.3.4#6332)