[ 
https://issues.apache.org/jira/browse/BEAM-231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15262394#comment-15262394
 ] 

ASF GitHub Bot commented on BEAM-231:
-------------------------------------

GitHub user swegner opened a pull request:

    https://github.com/apache/incubator-beam/pull/259

    [BEAM-231] Remove ClassForDisplay helper type

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/swegner/incubator-beam classfordisplay

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/259.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #259
    
----
commit d1513d512d7a82208c6cfb361996a21235348662
Author: Scott Wegner <sweg...@google.com>
Date:   2016-04-27T20:08:49Z

    Refactor Combine display data to not use ClassForDisplay

commit 39c8e5fd3aea8f03884b38301520f3b5dba1f72b
Author: Scott Wegner <sweg...@google.com>
Date:   2016-04-27T20:15:33Z

    Refactor DoFnReflector.SimpleDoFnAdapter to not use display data namespace 
override

commit d6f2a453803f25a8670d76ef46bfb39956f3a82b
Author: Scott Wegner <sweg...@google.com>
Date:   2016-04-27T20:25:12Z

    Remove ClassForDisplay helper type

commit 16e8d5a2b1901f0342e0bcc1b4d8736a0c8e337b
Author: Scott Wegner <sweg...@google.com>
Date:   2016-04-27T22:00:03Z

    Add test case for display data multi-level namespace overrides

----


> Remove ClassForDisplay infrastructure class.
> --------------------------------------------
>
>                 Key: BEAM-231
>                 URL: https://issues.apache.org/jira/browse/BEAM-231
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-java-core
>            Reporter: Scott Wegner
>
> See discussion here: 
> https://github.com/apache/incubator-beam/pull/247#discussion-diff-61184975
> This class should no longer be needed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to