[ https://issues.apache.org/jira/browse/BEAM-225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269249#comment-15269249 ]
ASF GitHub Bot commented on BEAM-225: ------------------------------------- GitHub user eljefe6a opened a pull request: https://github.com/apache/incubator-beam/pull/275 [BEAM-225] Create Class for Common TypeDescriptors Jira issue BEAM-225 Create Class for Common TypeDescriptors. Adding KVTypeDescriptors and TypeDescriptors to make primitives easier. You can merge this pull request into a Git repository by running: $ git pull https://github.com/eljefe6a/incubator-beam TypeDescriptors Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-beam/pull/275.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #275 ---- commit 8e89c7a9e390ec8026ee46d68d3a422f8917ef71 Author: Jesse Anderson <je...@smokinghand.com> Date: 2016-05-03T18:09:08Z Adding KVTypeDescriptors and TypeDescriptors to make primitives easier. ---- > Create Class for Common TypeDescriptors > --------------------------------------- > > Key: BEAM-225 > URL: https://issues.apache.org/jira/browse/BEAM-225 > Project: Beam > Issue Type: Bug > Components: sdk-java-core > Reporter: Jesse Anderson > Priority: Trivial > Labels: starter > > There should be a built-in class for common types like String, Float, etc. > Right now, all types have to create an inline TypeDescriptor: > {code:java} > PCollection<String> words = suits.apply( > FlatMapElements.via( > (String line) -> Arrays.asList(line.split(" ")) > ).withOutputType(new TypeDescriptor<String>() {})); > {code} > The should be a built-in class with common types like String so you don't > have to create a TypeDescriptor each time like: > {code:java} > PCollection<String> words = suits.apply( > FlatMapElements.via( > (String line) -> Arrays.asList(line.split(" ")) > ).withOutputType(TypeDescriptors.STRINGS)); > {code} > Another possibility is to make it a static method: > {code:java} > PCollection<String> words = suits.apply( > FlatMapElements.via( > (String line) -> Arrays.asList(line.split(" ")) > ).withOutputType(TypeDescriptors.strings())); > {code} > An example of this is Apache Crunch's Writables class > https://crunch.apache.org/apidocs/0.11.0/org/apache/crunch/types/writable/Writables.html. -- This message was sent by Atlassian JIRA (v6.3.4#6332)