[ https://issues.apache.org/jira/browse/BEAM-22?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15277124#comment-15277124 ]
ASF GitHub Bot commented on BEAM-22: ------------------------------------ GitHub user tgroh opened a pull request: https://github.com/apache/incubator-beam/pull/312 [BEAM-22] Update Watermarks Outside of handleResult Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make sure the PR title is formatted like: `[BEAM-<Jira issue #>] Description of pull request` - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable Travis-CI on your fork and ensure the whole test matrix passes). - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue number, if there is one. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt). --- This removes excess mutual exclusion, and reduces the eagerness of updating the value of a watermark. The first commit in this CR reviewed separately in #310 You can merge this pull request into a Git repository by running: $ git pull https://github.com/tgroh/incubator-beam ippr_wm_asynchronous Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-beam/pull/312.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #312 ---- commit 2d94540ccd02b19a73410647e84486c008d9cdc5 Author: Thomas Groh <tg...@google.com> Date: 2016-05-09T21:03:16Z Return null evaluators from Unavailable Reads Null TransformEvaluators for sources represent a source where all splits are currently in use or completed. Update TransformExecutor to handle null evaluators properly. Change TransformExecutor to a Runnable. commit 9ee1502e159cce49a8a4490593d896b34154e006 Author: Thomas Groh <tg...@google.com> Date: 2016-05-03T00:26:47Z Update Watermarks Outside of handleResult Remove excess mutual exclusion ---- > DirectPipelineRunner: support for unbounded collections > ------------------------------------------------------- > > Key: BEAM-22 > URL: https://issues.apache.org/jira/browse/BEAM-22 > Project: Beam > Issue Type: Improvement > Components: runner-direct > Reporter: Davor Bonaci > Assignee: Thomas Groh > > DirectPipelineRunner currently runs over bounded PCollections only, and > implements only a portion of the Beam Model. > We should improve it to faithfully implement the full Beam Model, such as add > ability to run over unbounded PCollections, and better resemble execution > model in a distributed system. > This further enables features such as a testing source which may simulate > late data and test triggers in the pipeline. Finally, we may want to expose > an option to select between "debug" (single threaded), "chaos monkey" (test > as many model requirements as possible), and "performance" (multi-threaded). > more testing (chaos monkey) > Once this is done, we should update this StackOverflow question: > http://stackoverflow.com/questions/35350113/testing-triggers-with-processing-time/35401426#35401426 -- This message was sent by Atlassian JIRA (v6.3.4#6332)