[ 
https://issues.apache.org/jira/browse/BEAM-306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15300312#comment-15300312
 ] 

ASF GitHub Bot commented on BEAM-306:
-------------------------------------

GitHub user mshields822 opened a pull request:

    https://github.com/apache/incubator-beam/pull/388

    [BEAM-306] Serialize/Deserialize checkpoints

    R: @dhalperi @tgroh 
    
    The PubsubUnboundendSource implementation has an assertion to confirm the 
checkpoint from which a fresh reader is instantiated has come via 
deserialization from an earlier finalized checkpoint. The in-process runner was 
reusing the checkpoint object directly, so the assertion failed. This adds the 
serialize/deserialize to the in-process runner, which I believe is the best 
solution since other UnboundedSources may be caught by the same issue. It also 
forces the user to exercise their checkpoint coder.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mshields822/incubator-beam pubsub-inproc

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/388.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #388
    
----
commit 4f4b526495a887bbc1c9b782850e9785a86bddc9
Author: Mark Shields <markshie...@google.com>
Date:   2016-05-25T16:13:07Z

    Serialize/Deserialize checkpoints

----


> Make java-only PubsubIO work in InProcessRunner 
> ------------------------------------------------
>
>                 Key: BEAM-306
>                 URL: https://issues.apache.org/jira/browse/BEAM-306
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-core
>            Reporter: Mark Shields
>            Assignee: Mark Shields
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to