[ https://issues.apache.org/jira/browse/BEAM-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15330838#comment-15330838 ]
ASF GitHub Bot commented on BEAM-341: ------------------------------------- GitHub user kennknowles opened a pull request: https://github.com/apache/incubator-beam/pull/464 [BEAM-341] Fix ReduceFnRunner GC time overflow Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [x] Make sure the PR title is formatted like: `[BEAM-<Jira issue #>] Description of pull request` - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable Travis-CI on your fork and ensure the whole test matrix passes). - [x] Replace `<Jira issue #>` in the title with the actual Jira issue number, if there is one. - [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt). --- You can merge this pull request into a Git repository by running: $ git pull https://github.com/kennknowles/incubator-beam gc-time Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-beam/pull/464.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #464 ---- commit 26662378aaf7bb08dde12c6d0fa64f2b490a0d4d Author: Kenneth Knowles <k...@google.com> Date: 2016-06-14T23:04:10Z Add test for ReduceFnRunner GC time overflow ---- > ReduceFnRunner allows GC time overflow > -------------------------------------- > > Key: BEAM-341 > URL: https://issues.apache.org/jira/browse/BEAM-341 > Project: Beam > Issue Type: Bug > Components: runner-core > Reporter: Kenneth Knowles > Assignee: Kenneth Knowles > > In {{ReduceFnRunner}}, any window ending after the global window has its GC > time capped to the end of the global window. But for windows ending before > the global window the allowed lateness can still be arbitrary, causing > overflow. > http://stackoverflow.com/questions/37808159/why-am-i-getting-java-lang-illegalstateexception-on-google-dataflow -- This message was sent by Atlassian JIRA (v6.3.4#6332)