[
https://issues.apache.org/jira/browse/BEAM-342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15331444#comment-15331444
]
ASF GitHub Bot commented on BEAM-342:
-------------------------------------
GitHub user manuzhang opened a pull request:
https://github.com/apache/incubator-beam/pull/468
[BEAM-342] Implement Filter#greaterThan,etc with Filter#byPredicate
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/manuzhang/incubator-beam BEAM-342
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/468.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #468
----
commit 7f761fc2bf81b8525aee9c1d9bcbc9aea1cb255e
Author: manuzhang <owenzhang1...@gmail.com>
Date: 2016-06-15T08:02:35Z
[BEAM-342] Implement Filter#greaterThan,etc with Filter#byPredicate
----
> Change Filter#greaterThan, etc. to actually use Filter
> ------------------------------------------------------
>
> Key: BEAM-342
> URL: https://issues.apache.org/jira/browse/BEAM-342
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Daniel Halperin
> Assignee: Manu Zhang
> Priority: Minor
> Labels: starter
>
> This is a good starter task.
> Right now,
> [{{Filter#greaterThan}}|https://github.com/apache/incubator-beam/blob/315b3c8e333e5f42730c19e89f856d778ce93cab/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Filter.java#L134]
> constructs a new DoFn rather than using {{Filter#byPredicate}}. We should
> fix this to make it consistent and simpler.
> We can also remove deprecated functions in that file, and if possible
> redundant display data.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
