[ 
https://issues.apache.org/jira/browse/BEAM-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15338724#comment-15338724
 ] 

ASF GitHub Bot commented on BEAM-357:
-------------------------------------

GitHub user rmannibucau opened a pull request:

    https://github.com/apache/incubator-beam/pull/496

    [BEAM-357] fixing build on windows

    Small fixes or workarounds for windows.
    
    Main issues were:
    
    - Paths.get(...): windows has ":" which will make it failing, using new 
File(...).toPath() to fix it
    - Workaround for hadoop which requires winutils.exe on windows (see 
https://issues.apache.org/jira/browse/BEAM-357 for a comment on it)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rmannibucau/incubator-beam 
BEAM-357_windows-build-fails

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/496.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #496
    
----
commit 418833001fe6dd581f42f7fcc3c35ef36f292007
Author: Romain manni-Bucau <rmannibu...@gmail.com>
Date:   2016-06-19T19:19:57Z

    fixing build on windows

----


> Build doesn't pass on windows
> -----------------------------
>
>                 Key: BEAM-357
>                 URL: https://issues.apache.org/jira/browse/BEAM-357
>             Project: Beam
>          Issue Type: Bug
>          Components: beam-model
>            Reporter: Romain Manni-Bucau
>            Assignee: Jean-Baptiste Onofré
>         Attachments: bean-win.diff
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to