[ 
https://issues.apache.org/jira/browse/BEAM-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351570#comment-15351570
 ] 

ASF GitHub Bot commented on BEAM-379:
-------------------------------------

GitHub user vikkyrk opened a pull request:

    https://github.com/apache/incubator-beam/pull/542

    BEAM-379: Add support for source Ptransform in DisplayDataEvaluator

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vikkyrk/incubator-beam 
vikasrk/display_evaluator

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/542.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #542
    
----

----


> DisplayDataEvaluator does not support source transforms of the form 
> PTransform<PBegin, ?>
> -----------------------------------------------------------------------------------------
>
>                 Key: BEAM-379
>                 URL: https://issues.apache.org/jira/browse/BEAM-379
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Vikas Kedigehalli
>            Assignee: Vikas Kedigehalli
>
> DisplayDataEvaluator 
> (https://github.com/apache/incubator-beam/blob/c0efe568e5291298c1394016a12e7979b37afc44/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/display/DisplayDataEvaluator.java#L81)
>  takes PTranform<? extends PCollection<InputT>, ? extends POutput>, but this 
> doesn't work for source transforms of the form PTransform<PBegin, 
> PCollection<T>>. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to