[
https://issues.apache.org/jira/browse/BEAM-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15377149#comment-15377149
]
ASF GitHub Bot commented on BEAM-339:
-------------------------------------
GitHub user swegner opened a pull request:
https://github.com/apache/incubator-beam/pull/654
[BEAM-339] Archetype project version shouldn't be coupled to Beam version
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
Follow-up from [a previous archetype
PR](https://github.com/apache/incubator-beam/pull/444/files/ba55042275bd9b525ee8716e4e1007b7924a647f#r66819150),
the maven artifact version for the generated project should not be tied to the
version of Beam. The generated module is a new user project, so the version
should represent "initial version", i.e. 0.1.
This PR drops the -SNAPSHOT suffix from the version and fixes the version
to 0.1 in our tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/swegner/incubator-beam archetype-version
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/654.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #654
----
commit 5b317b852b1fac9f6320e1a074238e6e7da77b79
Author: Scott Wegner <sweg...@google.com>
Date: 2016-07-13T22:59:16Z
Archetype generated projects shouldn't have SNAPSHOT version
----
> Archetype project version shouldn't be coupled to Beam version
> --------------------------------------------------------------
>
> Key: BEAM-339
> URL: https://issues.apache.org/jira/browse/BEAM-339
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-extensions
> Reporter: Scott Wegner
> Assignee: Scott Wegner
> Priority: Minor
>
> tl;dr: The maven-archetype project has a version reference of 0.1-SNAPSHOT.
> This is for the user project and shouldn't be tied to Beam versions.
>
> In the maven-archetype projects, we have a test which injects property values
> and verify that the generated project matches the expected. One of the
> injected properties is "version", which is currently set to "0.1-snapshot" to
> match the Beam project versions. The version property represents the version
> of the user project being created and thus shouldn't be tied to the Beam
> versioning. We should change it such that the intended usage is more clear
> and to test that the version isn't being set from the Beam version.
> See:
> https://github.com/apache/incubator-beam/pull/444/files/ba55042275bd9b525ee8716e4e1007b7924a647f#r66819150
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
