[ 
https://issues.apache.org/jira/browse/BEAM-462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15382496#comment-15382496
 ] 

ASF GitHub Bot commented on BEAM-462:
-------------------------------------

GitHub user lukecwik opened a pull request:

    https://github.com/apache/incubator-beam/pull/673

    [BEAM-462] Replace MonitoringUtil.PrintHandler with a handler that utilizes 
a Java logger

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lukecwik/incubator-beam logginghandler

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/673.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #673
    
----
commit f9dcca2f26add731b9412ddf3705d6bcb6726008
Author: Luke Cwik <lc...@google.com>
Date:   2016-07-18T15:51:32Z

    [BEAM-462] Replace MonitoringUtil.PrintHandler with a handler that utilizes 
a Java logger

----


> Replace MonitoringUtil.PrintHandler with a handler that utilizes a Java logger
> ------------------------------------------------------------------------------
>
>                 Key: BEAM-462
>                 URL: https://issues.apache.org/jira/browse/BEAM-462
>             Project: Beam
>          Issue Type: Improvement
>          Components: runner-dataflow
>            Reporter: Luke Cwik
>            Assignee: Luke Cwik
>            Priority: Minor
>
> The current PrintHandler in MonitoringUtil only supports output to a print 
> stream.
> It would be cleaner to instead have a LoggingHandler that can be used with 
> normal Java logging.  The handler could translate the JobMessage importance 
> to severity and thus allowing for formating/filtering to be determined by the 
> logger instead of custom printing code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to