[
https://issues.apache.org/jira/browse/BEAM-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15392448#comment-15392448
]
ASF GitHub Bot commented on BEAM-354:
-------------------------------------
GitHub user vikkyrk opened a pull request:
https://github.com/apache/incubator-beam/pull/725
[BEAM-354] Move V1Beta3 DatastoreSource into its own file
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
- No logic changes, just move DataSource to new file and rename to
V1Beta3Source
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vikkyrk/incubator-beam vikasrk/ds_refactor
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/725.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #725
----
commit 0f7ab24daa18788bef1083242c3a2a7d054c767f
Author: Vikas Kedigehalli <vika...@google.com>
Date: 2016-07-25T18:10:10Z
Move V1Beta3 DatastoreSource into its own file
----
> Modify DatastoreIO to use Datastore v1beta3 API
> -----------------------------------------------
>
> Key: BEAM-354
> URL: https://issues.apache.org/jira/browse/BEAM-354
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-gcp
> Affects Versions: 0.2.0-incubating
> Reporter: Vikas Kedigehalli
> Assignee: Vikas Kedigehalli
> Fix For: 0.2.0-incubating
>
>
> Datastore v1beta2 API is getting deprecated in favor of v1beta3. Hence the
> DatastoreIO needs to be migrated to use the new version. Also in the process
> of doing so, this is a good time to add a level of indirection via a
> PTranform such that future changes in Datastore API would not result in
> changing user/pipeline code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
