[ https://issues.apache.org/jira/browse/BEAM-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15396678#comment-15396678 ]
ASF GitHub Bot commented on BEAM-156: ------------------------------------- GitHub user tgroh opened a pull request: https://github.com/apache/incubator-beam/pull/745 [BEAM-156] Apply ExecutorUpdates in two Phases Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make sure the PR title is formatted like: `[BEAM-<Jira issue #>] Description of pull request` - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable Travis-CI on your fork and ensure the whole test matrix passes). - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue number, if there is one. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt). --- This removes the need for an explicit break by ensuring that work added by the monitor will not complete and add more work for the monitor to complete. You can merge this pull request into a Git repository by running: $ git pull https://github.com/tgroh/incubator-beam two_phase_executor_update Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-beam/pull/745.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #745 ---- commit 4b932d93352b04f60392b6083ce5573c86535a65 Author: Thomas Groh <tg...@google.com> Date: 2016-07-22T20:47:19Z Apply ExecutorUpdates in two Phases This removes the need for an explicit break by ensuring that work added by the monitor will not complete and add more work for the monitor to complete. ---- > Implement Quiescence Signalling in the InProcessPipelineRunner > -------------------------------------------------------------- > > Key: BEAM-156 > URL: https://issues.apache.org/jira/browse/BEAM-156 > Project: Beam > Issue Type: Improvement > Components: sdk-java-core > Reporter: Thomas Groh > Assignee: Thomas Groh > > A pipeline is quiescent when the following two properties hold: > There are no triggers that can fire, given the current processing time and > watermark > All pending elements cannot make progress until a side input produces > additional output > This is approximately equivalent to: If no more input is received, the > pipeline will not perform any additional processing absent advances in > processing time or event time > See also: > https://docs.google.com/document/d/1fZUUbG2LxBtqCVabQshldXIhkMcXepsbv2vuuny8Ix4/edit# -- This message was sent by Atlassian JIRA (v6.3.4#6332)