[ https://issues.apache.org/jira/browse/BEAM-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15400066#comment-15400066 ]
ASF GitHub Bot commented on BEAM-444: ------------------------------------- Github user peihe closed the pull request at: https://github.com/apache/incubator-beam/pull/643 > Promote isBlockOnRun() to PipelineOptions. > ------------------------------------------ > > Key: BEAM-444 > URL: https://issues.apache.org/jira/browse/BEAM-444 > Project: Beam > Issue Type: New Feature > Reporter: Pei He > Assignee: Pei He > > Currently, blockOnRun is implemented in different ways by runners. > DirectRunner did blockOnRun based on DirectOptions.isBlockOnRun. > Dataflow have a separate BlockingDataflowRunner. > Flink and Spark runners might or might not block depends on their > implementation on run(). > I think DirectRunner's approach is the right way to go, and isBlockOnRun > options need to be promoted to the general PipelineOptions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)