[
https://issues.apache.org/jira/browse/BEAM-569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15441377#comment-15441377
]
ASF GitHub Bot commented on BEAM-569:
-------------------------------------
GitHub user jbonofre opened a pull request:
https://github.com/apache/incubator-beam/pull/898
[BEAM-569] Define maxNumRecords default value to Long.MAX_VALUE in JmsIO
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [X] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [X] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [X] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [X] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbonofre/incubator-beam BEAM-569
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/898.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #898
----
commit 086637ae726a28a9cc133d022adb01b11939c7f3
Author: Jean-Baptiste Onofré <jbono...@apache.org>
Date: 2016-08-27T12:01:34Z
[BEAM-569] Define maxNumRecords default value to Long.MAX_VALUE in JmsIO
----
> JMS IO should set maxNumRecords to Long.MAX_VALUE by default
> ------------------------------------------------------------
>
> Key: BEAM-569
> URL: https://issues.apache.org/jira/browse/BEAM-569
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-extensions
> Reporter: Jean-Baptiste Onofré
> Assignee: Jean-Baptiste Onofré
> Fix For: 0.3.0-incubating
>
>
> When using JmsIO this way:
> {code}
> JmsIO.read().withConnectionFactory(connectionFactory).withQueue("queue")
> {code}
> the user expects to work in unbounded mode. However, as the {{maxNumRecords}}
> value is not set by default in {{JmsIO}}, the default value set is {{0}} (as
> it's a {{long}}). It means that the {{JmsIO.read()}} just doesn't consume any
> message and exit directly.
> IMHO, it makes sense to define the {{maxNumRecords}} value to
> {{Long.MAX_VALUE}} by default. Thanks to that, {{JmsIO.read()}} will really
> work in unbounded form.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
