[ https://issues.apache.org/jira/browse/BEAM-672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Luke Cwik updated BEAM-672: --------------------------- Labels: test (was: ) > Figure out TestPipeline.create(PipelineOptions) / > TestPipeline.fromOptions(PipelineOptions) story > ------------------------------------------------------------------------------------------------- > > Key: BEAM-672 > URL: https://issues.apache.org/jira/browse/BEAM-672 > Project: Beam > Issue Type: Improvement > Components: sdk-java-core > Reporter: Luke Cwik > Priority: Minor > Labels: test > > TestPipeline integrates with the integration testing environment and relies > heavily on being able to be configured by the environment and executed on > many runners. > Tests which rely on mutating PipelineOptions before creating the TestPipeline > easily can get the integration wrong by creating PipelineOptions from > PipelineOptionsFactory and then calling either TestPipeline.create(options) > or TestPipeline.fromOptions(options), thus ignoring any integration > environment pipeline options specified. > We should fix the exposed methods on TestPipeline to prevent users from > making this simple mistake. > One suggestion is to create a TestPipeline builder which will give access to > a mutable PipelineOptions which the user can edit before calling build() > creating a TestPipeline. -- This message was sent by Atlassian JIRA (v6.3.4#6332)