[
https://issues.apache.org/jira/browse/BEAM-794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15595122#comment-15595122
]
ASF GitHub Bot commented on BEAM-794:
-------------------------------------
GitHub user amitsela opened a pull request:
https://github.com/apache/incubator-beam/pull/1153
[BEAM-794] Differ combining in case of merging windows with sideInputs.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [x] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [x] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/amitsela/incubator-beam BEAM-794
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/1153.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1153
----
commit ee5bcecb3c6ce51a2531d2c6ff36a6a99038d32f
Author: Sela <ans...@paypal.com>
Date: 2016-10-21T13:00:57Z
[BEAM-794] Differ combining in case of merging windows with sideInputs.
----
> Differ combining in case of merging windows with sideInputs
> ------------------------------------------------------------
>
> Key: BEAM-794
> URL: https://issues.apache.org/jira/browse/BEAM-794
> Project: Beam
> Issue Type: Bug
> Components: runner-spark
> Reporter: Amit Sela
> Assignee: Amit Sela
>
> For background, see BEAM-696.
> If a Combine transformation is applied to a PCollection with merging windows
> and sideInput, the runner should differ the execution of Combine.
> For the SparkRunner this means that it should use groupByKey instead of
> combinePerKey/Globally.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
