Remove unused GroupAlsoByWindowsDoFn.createDefault
Project: http://git-wip-us.apache.org/repos/asf/incubator-beam/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-beam/commit/5ce3aac2 Tree: http://git-wip-us.apache.org/repos/asf/incubator-beam/tree/5ce3aac2 Diff: http://git-wip-us.apache.org/repos/asf/incubator-beam/diff/5ce3aac2 Branch: refs/heads/apex-runner Commit: 5ce3aac2d3b7203b0cbab52c394a99142a46a5cf Parents: f603d43 Author: Kenneth Knowles <k...@google.com> Authored: Fri Oct 21 15:51:08 2016 -0700 Committer: Kenneth Knowles <k...@google.com> Committed: Tue Oct 25 13:04:17 2016 -0700 ---------------------------------------------------------------------- .../runners/core/GroupAlsoByWindowsDoFn.java | 19 ------------------- 1 file changed, 19 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/5ce3aac2/runners/core-java/src/main/java/org/apache/beam/runners/core/GroupAlsoByWindowsDoFn.java ---------------------------------------------------------------------- diff --git a/runners/core-java/src/main/java/org/apache/beam/runners/core/GroupAlsoByWindowsDoFn.java b/runners/core-java/src/main/java/org/apache/beam/runners/core/GroupAlsoByWindowsDoFn.java index 9851449..1b32d84 100644 --- a/runners/core-java/src/main/java/org/apache/beam/runners/core/GroupAlsoByWindowsDoFn.java +++ b/runners/core-java/src/main/java/org/apache/beam/runners/core/GroupAlsoByWindowsDoFn.java @@ -17,15 +17,12 @@ */ package org.apache.beam.runners.core; -import org.apache.beam.sdk.coders.Coder; import org.apache.beam.sdk.transforms.Aggregator; import org.apache.beam.sdk.transforms.OldDoFn; import org.apache.beam.sdk.transforms.Sum; import org.apache.beam.sdk.transforms.windowing.BoundedWindow; import org.apache.beam.sdk.util.SystemDoFnInternal; import org.apache.beam.sdk.util.WindowedValue; -import org.apache.beam.sdk.util.WindowingStrategy; -import org.apache.beam.sdk.util.state.StateInternalsFactory; import org.apache.beam.sdk.values.KV; /** @@ -47,20 +44,4 @@ public abstract class GroupAlsoByWindowsDoFn<K, InputT, OutputT, W extends Bound createAggregator(DROPPED_DUE_TO_CLOSED_WINDOW_COUNTER, new Sum.SumLongFn()); protected final Aggregator<Long, Long> droppedDueToLateness = createAggregator(DROPPED_DUE_TO_LATENESS_COUNTER, new Sum.SumLongFn()); - - /** - * Create the default {@link GroupAlsoByWindowsDoFn}, which uses window sets to implement the - * grouping. - * - * @param windowingStrategy The window function and trigger to use for grouping - * @param inputCoder the input coder to use - */ - public static <K, V, W extends BoundedWindow> - GroupAlsoByWindowsDoFn<K, V, Iterable<V>, W> createDefault( - WindowingStrategy<?, W> windowingStrategy, - StateInternalsFactory<K> stateInternalsFactory, - Coder<V> inputCoder) { - return new GroupAlsoByWindowsViaOutputBufferDoFn<>( - windowingStrategy, stateInternalsFactory, SystemReduceFn.<K, V, W>buffering(inputCoder)); - } }