[ 
https://issues.apache.org/jira/browse/BEAM-898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15634754#comment-15634754
 ] 

ASF GitHub Bot commented on BEAM-898:
-------------------------------------

GitHub user markflyhigh opened a pull request:

    https://github.com/apache/incubator-beam/pull/1279

    [BEAM-898] Remove @Default from IT options

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    Fix integration tests failure. It's related to 
[PR-1159](https://github.com/apache/incubator-beam/pull/1159)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/markflyhigh/incubator-beam 
fix-IT-PipelineOptions

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1279.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1279
    
----
commit 749f9de01b0f38a02b693d67b2457d8e55dee7f7
Author: Mark Liu <mark...@markliu0.mtv.corp.google.com>
Date:   2016-11-03T23:45:43Z

    Remove @Default from IT options

----


> BigQueryTornadoes IT has invalid PipelineOptions
> ------------------------------------------------
>
>                 Key: BEAM-898
>                 URL: https://issues.apache.org/jira/browse/BEAM-898
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-gcp, testing
>            Reporter: Daniel Halperin
>            Assignee: Mark Liu
>
> https://builds.apache.org/job/beam_PostCommit_MavenVerify/1718/
> This PR: https://github.com/apache/incubator-beam/pull/1159
> checks that pipeline options cannot have multiple incompatible defaults.
> BigQueryTornadoes ITs have a problem with how they register pipeline options. 
> Luke can give more details on fix.
> cc [~pei...@gmail.com] [~lcwik] [~jasonkuster]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to