GitHub user kennknowles opened a pull request:
https://github.com/apache/incubator-beam/pull/1318
[BEAM-922] Fix findbugs errors and re-enable for runners-core
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [x] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [x] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
R: @dhalperi
The error in `UnboundedReadFromBoundedSource` was a real coding error;
please review my small edit there.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennknowles/incubator-beam
runners-core-findbugs
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/1318.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1318
----
commit 2a4f6fffcdcf1804b1c173d6e4ab43ffc0431cb7
Author: Kenneth Knowles <k...@google.com>
Date: 2016-11-08T22:49:09Z
Fix findbugs errors and re-enable for runners-core
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
