[BEAM-930] Fix findbugs and re-enable Maven plugin in MongoDbIO
Project: http://git-wip-us.apache.org/repos/asf/incubator-beam/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-beam/commit/7c87c662 Tree: http://git-wip-us.apache.org/repos/asf/incubator-beam/tree/7c87c662 Diff: http://git-wip-us.apache.org/repos/asf/incubator-beam/diff/7c87c662 Branch: refs/heads/master Commit: 7c87c662db99e581e28e3198c90d2f43a8eebe6d Parents: 2bc66f9 Author: Jean-Baptiste Onofré <jbono...@apache.org> Authored: Mon Nov 14 16:10:53 2016 +0100 Committer: Dan Halperin <dhalp...@google.com> Committed: Tue Nov 15 04:02:08 2016 -0800 ---------------------------------------------------------------------- sdks/java/io/mongodb/pom.xml | 13 ------------- .../java/org/apache/beam/sdk/io/mongodb/MongoDbIO.java | 4 ++-- 2 files changed, 2 insertions(+), 15 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/7c87c662/sdks/java/io/mongodb/pom.xml ---------------------------------------------------------------------- diff --git a/sdks/java/io/mongodb/pom.xml b/sdks/java/io/mongodb/pom.xml index 17dc6e7..4b100a9 100644 --- a/sdks/java/io/mongodb/pom.xml +++ b/sdks/java/io/mongodb/pom.xml @@ -31,19 +31,6 @@ <description>IO to read and write on MongoDB.</description> <build> - <pluginManagement> - <plugins> - <!-- BEAM-930 --> - <plugin> - <groupId>org.codehaus.mojo</groupId> - <artifactId>findbugs-maven-plugin</artifactId> - <configuration> - <skip>true</skip> - </configuration> - </plugin> - </plugins> - </pluginManagement> - <plugins> <plugin> <groupId>org.apache.maven.plugins</groupId> http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/7c87c662/sdks/java/io/mongodb/src/main/java/org/apache/beam/sdk/io/mongodb/MongoDbIO.java ---------------------------------------------------------------------- diff --git a/sdks/java/io/mongodb/src/main/java/org/apache/beam/sdk/io/mongodb/MongoDbIO.java b/sdks/java/io/mongodb/src/main/java/org/apache/beam/sdk/io/mongodb/MongoDbIO.java index 2729602..71c017d 100644 --- a/sdks/java/io/mongodb/src/main/java/org/apache/beam/sdk/io/mongodb/MongoDbIO.java +++ b/sdks/java/io/mongodb/src/main/java/org/apache/beam/sdk/io/mongodb/MongoDbIO.java @@ -224,7 +224,7 @@ public class MongoDbIO { BasicDBObject stat = new BasicDBObject(); stat.append("collStats", spec.collection()); Document stats = mongoDatabase.runCommand(stat); - return Long.valueOf(stats.get("size").toString()); + return Long.parseLong(stats.get("size").toString()); } @Override @@ -456,7 +456,7 @@ public class MongoDbIO { private static class WriteFn extends DoFn<Document, Void> { private final Write spec; - private MongoClient client; + private transient MongoClient client; private List<Document> batch; public WriteFn(Write spec) {
