[ 
https://issues.apache.org/jira/browse/BEAM-930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15667382#comment-15667382
 ] 

ASF GitHub Bot commented on BEAM-930:
-------------------------------------

GitHub user jbonofre opened a pull request:

    https://github.com/apache/incubator-beam/pull/1361

    [BEAM-930] Fix findbugs and re-enable Maven plugin in MongoDbIO and 
MongoDbGridFSIO

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [X] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [X] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [X] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [X] If this contribution is large, please file an Apache
           [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jbonofre/incubator-beam BEAM-930

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1361.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1361
    
----

----


> Findbugs doesn't pass in MongoDB
> --------------------------------
>
>                 Key: BEAM-930
>                 URL: https://issues.apache.org/jira/browse/BEAM-930
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-extensions
>            Reporter: Daniel Halperin
>            Assignee: Jean-Baptiste Onofré
>             Fix For: 0.4.0-incubating
>
>
> {code}
> [INFO] --- findbugs-maven-plugin:3.0.1:check (default) @ 
> beam-sdks-java-io-mongodb ---
> [INFO] BugInstance size is 2
> [INFO] Error size is 0
> [INFO] Total bugs: 2
> [INFO] Boxing/unboxing to parse a primitive 
> org.apache.beam.sdk.io.mongodb.MongoDbIO$BoundedMongoDbSource.getEstimatedSizeBytes(PipelineOptions)
>  [org.apache.beam.sdk.io.mongodb.MongoDbIO$BoundedMongoDbSource] At 
> MongoDbIO.java:[line 227]
> [INFO] Class org.apache.beam.sdk.io.mongodb.MongoDbIO$Write$WriteFn defines 
> non-transient non-serializable instance field client 
> [org.apache.beam.sdk.io.mongodb.MongoDbIO$Write$WriteFn] In MongoDbIO.java
> [INFO]  
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to