[ https://issues.apache.org/jira/browse/BEAM-800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15689394#comment-15689394 ]
ASF GitHub Bot commented on BEAM-800: ------------------------------------- GitHub user manuzhang opened a pull request: https://github.com/apache/incubator-beam/pull/1428 [BEAM-800] add getFn to DoFnInvoker Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make sure the PR title is formatted like: `[BEAM-<Jira issue #>] Description of pull request` - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable Travis-CI on your fork and ensure the whole test matrix passes). - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue number, if there is one. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt). --- You can merge this pull request into a Git repository by running: $ git pull https://github.com/manuzhang/incubator-beam add-DoFn-DoFnInvoker Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-beam/pull/1428.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1428 ---- ---- > DoFnLifeCycleManager should hold DoFnInvoker, not DoFn/OldDoFn > -------------------------------------------------------------- > > Key: BEAM-800 > URL: https://issues.apache.org/jira/browse/BEAM-800 > Project: Beam > Issue Type: Bug > Components: runner-direct > Reporter: Kenneth Knowles > Assignee: Manu Zhang > Priority: Minor > > The {{DirectRunner}}'s support class {{DoFnLifecycleManager}} holds a cache > of deserialized {{OldDoFn}} s, now being ported to {{DoFn}} s. But to execute > a {{DoFn}} there is another layer of indirection through a {{DoFnInvoker}}, > which is the best object to cache here. -- This message was sent by Atlassian JIRA (v6.3.4#6332)