[
https://issues.apache.org/jira/browse/BEAM-986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15710185#comment-15710185
]
ASF GitHub Bot commented on BEAM-986:
-------------------------------------
GitHub user kennknowles opened a pull request:
https://github.com/apache/incubator-beam/pull/1474
[BEAM-986] Revert "Improvements to ReduceFnRunner prefetching"
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [x] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [x] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
This reverts commit 4282c67c5fa4dea2fe6c8695e0ea23f383c6457b, which
contained some incompatibilities outside of runners-core. The PR is #1366, for
reference.
R: anyone, pinging @tgroh or @dhalperi
CC: @scwhittle
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennknowles/incubator-beam rollback
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/1474.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1474
----
commit aaa3b91e1e7b39dd585314a6017235cdd127e923
Author: Kenneth Knowles <k...@google.com>
Date: 2016-11-30T23:21:53Z
Revert "Improvements to ReduceFnRunner prefetching"
This reverts commit 4282c67c5fa4dea2fe6c8695e0ea23f383c6457b, which
contained some incompatibilities outside of runners-core.
----
> ReduceFnRunner doesn't batch prefetching pane firings
> -----------------------------------------------------
>
> Key: BEAM-986
> URL: https://issues.apache.org/jira/browse/BEAM-986
> Project: Beam
> Issue Type: Bug
> Components: runner-core
> Reporter: Sam Whittle
> Assignee: Sam Whittle
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Specifically
> - in ProcessElements, if there are multiple windows to consider each is
> processed sequentially with sequential state fetches instead of a bulk
> prefetch
> - onTimer method doesn't evaluate multiple timers at a time meaning that if
> multiple timers are fired at once each is processed sequentially without
> batched prefetching
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
