GitHub user tgroh opened a pull request: https://github.com/apache/incubator-beam/pull/1484
Migrate TransformTreeNode to an Inner Class Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make sure the PR title is formatted like: `[BEAM-<Jira issue #>] Description of pull request` - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable Travis-CI on your fork and ensure the whole test matrix passes). - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue number, if there is one. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt). --- You can merge this pull request into a Git repository by running: $ git pull https://github.com/tgroh/incubator-beam transform_hierarchy_maintenance_internally Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-beam/pull/1484.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1484 ---- commit 1fab0da2bdfb7675fc3aa5f0faf81e2dcfe867fb Author: Thomas Groh <tg...@google.com> Date: 2016-12-01T21:19:14Z Migrate TransformTreeNode to an Inner Class TransformTreeNode requires access to the hierarchy it is contained within, and generally cannot be separated from TransformHierarchy. It is primarily an implementation detail of TransformHierarchy, so can be relocated to within it. commit 3d44a4a0709fbe1ebb25d0dea7f927415fa370a1 Author: Thomas Groh <tg...@google.com> Date: 2016-12-01T21:22:11Z Reduce the visibility of TransformHierarchy Node Mutators These mutators should not be accessible when visiting the nodes. ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---