[
https://issues.apache.org/jira/browse/BEAM-1065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15729597#comment-15729597
]
ASF GitHub Bot commented on BEAM-1065:
--------------------------------------
Github user peihe closed the pull request at:
https://github.com/apache/incubator-beam/pull/1426
> FileBasedSource: replace SeekableByteChannel with open(spec, startingPosition)
> ------------------------------------------------------------------------------
>
> Key: BEAM-1065
> URL: https://issues.apache.org/jira/browse/BEAM-1065
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-java-core
> Reporter: Pei He
> Assignee: Pei He
>
> FileBasedReader should be able to open the file with the
> Source.getStartOffset(), and then read forward to find the first input
> element.
> The benefits are:
> 1. It is easier to implement a ReadableByteChannel.
> 2. Dynamically splitting won't require file systems to support seeking.
> 3. Doesn't need to seek to position twice, which is what current API does.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
