[
https://issues.apache.org/jira/browse/BEAM-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15730359#comment-15730359
]
ASF GitHub Bot commented on BEAM-646:
-------------------------------------
GitHub user tgroh opened a pull request:
https://github.com/apache/incubator-beam/pull/1547
[BEAM-646] Add PTransformOverrideFactory to the Core SDK
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
This migrates PTransformOverrideFactory from the DirectRunner to the
Core SDK, as part of BEAM-646.
Migrate all DirectRunner Override Factories to the new
PTransformOverrideFactory.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tgroh/incubator-beam override_factory_in_core
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/1547.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1547
----
commit ad7aa03e12694bceb29906d2bb9df1ce009a1df2
Author: Thomas Groh <tg...@google.com>
Date: 2016-12-06T00:01:57Z
Add PTransformOverrideFactory to the Core SDK
This migrates PTransformOverrideFactory from the DirectRunner to the
Core SDK, as part of BEAM-646.
Add getOriginalToReplacements to provide a mapping from the original
outputs to replaced outputs. This enables all replaced nodes to be
rewired to output the original output.
Migrate all DirectRunner Override Factories to the new
PTransformOverrideFactory.
----
> Get runners out of the apply()
> ------------------------------
>
> Key: BEAM-646
> URL: https://issues.apache.org/jira/browse/BEAM-646
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Kenneth Knowles
> Assignee: Thomas Groh
>
> Right now, the runner intercepts calls to apply() and replaces transforms as
> we go. This means that there is no "original" user graph. For portability and
> misc architectural benefits, we would like to build the original graph first,
> and have the runner override later.
> Some runners already work in this manner, but we could integrate it more
> smoothly, with more validation, via some handy APIs on e.g. the Pipeline
> object.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
